What's new
What's new

Variable Programming - Critique My Code, Please

NiCu2829

Plastic
Joined
Jun 16, 2018
I've attached the blueprint of the part to be made and my code to machine the 5 slots in the OD. My goal is to have a program that regardless of the tool diameter, programmed radius or # of passes/DOC can be changed with relative ease. I'd like to make #527 passes where each pass is #528/#527 deep (the actual DOC is [#528/#527]/2 because the Y axis is diametrical).
I've never used variables to this extent so I'm hoping y'all will look it over and critique my code.

In the program I accounted for the key cutter tool radius when I programmed the tool path, so the R value on the offset screen=0.

I'm cutting on the minus(-) side of Y0.

Thanks in advance!
 

Attachments

  • DWG3.PNG
    DWG3.PNG
    10.9 KB · Views: 91
  • DWG2.jpg
    DWG2.jpg
    16.3 KB · Views: 124
  • DWG1.jpg
    DWG1.jpg
    18.5 KB · Views: 120
  • 208.txt
    1.2 KB · Views: 62
Here's what I use for my programs. Easy to change depth of cut and number of passes.
#511 would be stock condition
#940 would be DOC
The 1 in the following statement [[#599-1] is the first N number


(CYCLE START)

N1(1st Pass O7010)
(ID UNDER RAIL)
#599=1
#3002=0
#7=#0
#598=[#511-[[#599-1]*#940]]
IF[#598LE0]THEN#598=0
IF[#598EQ0]GOTO11
#5221=#505-#598(X SHIFT)
#5222=#506(Y SHIFT)
#5223=#507-#598(Z SHIFT)
#5224=#508(B SHIFT)
#5226=#509(C SHIFT)
#2001=#510(DIAMETER REG. D01)
(CYCLE START)
G91G28Z0.0
M98P7010 (RUN O7010)

M01

N2(2ND PASS O7010)
(ID UNDER RAIL)
#599=2
#598=[#511-[[#599-1]*#940]]
IF[#598LE0]THEN#598=0
IF[#598EQ0]GOTO11
#5221=#505-#598(X SHIFT)
#5222=#506(Y SHIFT)
#5223=#507-#598(Z SHIFT)
#5224=#508(B SHIFT)
#5226=#509(C SHIFT)
#2001=#510(DIAMETER REG. D01)
(CYCLE START)
M98P7010(RUN O7010)

M01

N3(3RD PASS O7010)
(ID UNDER RAIL)
#599=3
#598=[#511-[[#599-1]*#940]]
IF[#598LE0]THEN#598=0
IF[#598EQ0]GOTO11
#5221=#505-#598(X SHIFT)
#5222=#506(Y SHIFT)
#5223=#507-#598(Z SHIFT)
#5224=#508(B SHIFT)
#5226=#509(C SHIFT)
#2001=#510(DIAMETER REG. D01)
(CYCLE START)
M98P7010(RUN O7010)

M01

N4(4TH PASS O7010)
(ID UNDER RAIL)
#599=4
#598=[#511-[[#599-1]*#940]]
IF[#598LE0]THEN#598=0
IF[#598EQ0]GOTO11
#5221=#505-#598(X SHIFT)
#5222=#506(Y SHIFT)
#5223=#507-#598(Z SHIFT)
#5224=#508(B SHIFT)
#5226=#509(C SHIFT)
#2001=#510(DIAMETER REG. D01)
(CYCLE START)
M98P7010(RUN O7010)

M01

N5(5TH PASS O7010)
(ID UNDER RAIL)
#599=5
#598=[#511-[[#599-1]*#940]]
IF[#598LE0]THEN#598=0
IF[#598EQ0]GOTO11
#5221=#505-#598(X SHIFT)
#5222=#506(Y SHIFT)
#5223=#507-#598(Z SHIFT)
#5224=#508(B SHIFT)
#5226=#509(C SHIFT)
#2001=#510(DIAMETER REG. D01)
(CYCLE START)
M98P7010(RUN O7010)

M01

N6(6TH PASS O7010)
(ID UNDER RAIL)
#599=6
#598=[#511-[[#599-1]*#940]]
IF[#598LE0]THEN#598=0
IF[#598EQ0]GOTO11
#5221=#505-#598(X SHIFT)
#5222=#506(Y SHIFT)
#5223=#507-#598(Z SHIFT)
#5224=#508(B SHIFT)
#5226=#509(C SHIFT)
#2001=#510(DIAMETER REG. D01)
(CYCLE START)
M98P7010(RUN O7010)

M01

N7(7TH PASS O7010)
(ID UNDER RAIL)
#599=7
#598=[#511-[[#599-1]*#940]]
IF[#598LE0]THEN#598=0
IF[#598EQ0]GOTO11
#5221=#505-#598(X SHIFT)
#5222=#506(Y SHIFT)
#5223=#507-#598(Z SHIFT)
#5224=#508(B SHIFT)
#5226=#509(C SHIFT)
#2001=#510(DIAMETER REG. D01)
(CYCLE START)
M98P7010(RUN O7010)

M01

N8(8TH PASS O7010)
(ID UNDER RAIL)
#599=8
#598=[#511-[[#599-1]*#940]]
IF[#598LE0]THEN#598=0
IF[#598EQ0]GOTO11
#5221=#505-#598(X SHIFT)
#5222=#506(Y SHIFT)
#5223=#507-#598(Z SHIFT)
#5224=#508(B SHIFT)
#5226=#509(C SHIFT)
#2001=#510(DIAMETER REG. D01)
(CYCLE START)
M98P7010(RUN O7010)

M01

N9(9TH PASS O7010)
(ID UNDER RAIL)
#599=9
#598=[#511-[[#599-1]*#940]]
IF[#598LE0]THEN#598=0
IF[#598EQ0]GOTO11
#5221=#505-#598(X SHIFT)
#5222=#506(Y SHIFT)
#5223=#507-#598(Z SHIFT)
#5224=#508(B SHIFT)
#5226=#509(C SHIFT)
#2001=#510(DIAMETER REG. D01)
(CYCLE START)
M98P7010(RUN O7010)

M01

N10(10TH PASS O7010)
(ID UNDER RAIL)
#599=10
#598=[#511-[[#599-1]*#940]]
IF[#598LE0]THEN#598=0
IF[#598EQ0]GOTO11
#5221=#505-#598(X SHIFT)
#5222=#506(Y SHIFT)
#5223=#507-#598(Z SHIFT)
#5224=#508(B SHIFT)
#5226=#509(C SHIFT)
#2001=#510(DIAMETER REG. D01)
(CYCLE START)
M98P7010(RUN O7010)

M01

N11(Semi Finish PASS O7010)
(ID UNDER RAIL)
#599=11
#5221=#505-.007(X SHIFT)
#5222=#506(Y SHIFT)
#5223=#507-.007(Z SHIFT)
#5224=#508(B SHIFT)
#5226=#509(C SHIFT)
#2001=#510(DIAMETER REG. D01)
(CYCLE START)
M98P7010(RUN O7010)

M01

N12(Finish Pass O7010)
(ID UNDER RAIL)
#599=12
#5221=#505(X SHIFT)
#5222=#506(Y SHIFT)
#5223=#507(Z SHIFT)
#5224=#508(B SHIFT)
#5226=#509(C SHIFT)
#2001=#510(DIAMETER REG. D01)
(CYCLE START)
M98P7010(RUN O7010)
 








 
Back
Top